Revert recent changes to opaque type proxy generation #23059
Merged
+65
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22974 (all of the different minimisations are added as tests here)
Reopens #22359, #17243 (I'll reopen these manually after merging this)
I tried to fix the errors causing the regressions in #23030, but so far it has been taking too much time, with every added fix causing other tests to fail. Preferably, we should unblock Kyo (and its users) sooner than later. I hope to revisit all of this one day, and resubmit a fix again, this time taking into account the minimisations included here.