Skip to content

Fix completion mode filtering + optimize scopeCompletions #23172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rochala
Copy link
Contributor

@rochala rochala commented May 15, 2025

I've changed scopeCompletions to lazy val to memoize because I beliveve we don't need to recompute it. The actual fix is at the comment. There is no need to create a new Completer just to filter all of remaining completions at later stage.

Fixes #23150

Copy link
Member

@kasiaMarek kasiaMarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself seems fine, though there are a lot of unrelated changes here, so it's hard to know what exactly I'm looking at.

@rochala
Copy link
Contributor Author

rochala commented May 21, 2025

Actually, the only unrelated change here is the change of { into fewer braces. The rest was necessary to handle all the test cases.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presentation compiler still tries to complete package definition
3 participants