[WIP] Fix #3007: Added silencing of the output in initial and cleanup commands

[SzymonPajzert]

Implementing the feature requested in #3007 by dropping the output of the executed commands.

[dottybot]

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

1. Separate subject from body with a blank line
2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
3. Limit the subject line to 72 characters
4. Capitalize the subject line
5. Do not end the subject line with a period
6. Use the imperative mood in the subject line ("Add" instead of "Added")
7. Wrap the body at 80 characters
8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

[allanrenucci]

Thanks @SzymonPajzert. I'll take a look when I'm back from vacation

[allanrenucci]

I think this is the right approach to implement a silent mode for the REPL. However, the issue description was erroneous and initialCommands and cleanupCommands should not be interpreted in a silent mode (see #3007 (comment)).

The silent mode could be useful to implement value bindings. I would implement everything in ConsoleInterface. Something along the line of:

val driver = new ReplDriver(completeArgs, classLoader = Some(loader))
val initState = driver.initState
val s0 = (bindNames, bindValues).zipped.folLeft(initState) {
  case (state, (name, value)) => driver.bind(name, value)(state)
}
val s1 = driver.run(initialCommands)(s0)
// handle failure during initialisation
val s2 = driver.runUntilQuit(s1)
driver.run(s1)

Value bindings can be implemented in a different PR

[allanrenucci]

We will need to open issues for this and value bindings

[SzymonPajzert]

I have created #5069 to implement the bindings, but I don't understand how failure during initialization should be signaled. Should we mark it with some checked exception?

[allanrenucci]

Yes the current API that returns a state is not ideal. Let's not worry about it here, it can be fixed in a separate PR

[allanrenucci]

Otherwise LGTM. Please squash your commits

[SzymonPajzert]

Is there any linter available to not submit changes with nitpicks?

[allanrenucci]

Is there any linter available to not submit changes with nitpicks?

No. At some point we talked about using scalafmt, but we decided not to enforce a specific style

One last think before we merge (sorry I didn't spot it earlier). Can you update the commit message to not mention silencing anymore. Something like: Fix #3007: Add support for initial and cleanup command in the REPL

[allanrenucci]

Thanks @SzymonPajzert! 🎉