IDE: Support textDocument/signatureHelp
#5395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Nov 9, 2018
language-server/src/dotty/tools/languageserver/Signatures.scala
Outdated
Show resolved
Hide resolved
language-server/src/dotty/tools/languageserver/Signatures.scala
Outdated
Show resolved
Hide resolved
language-server/src/dotty/tools/languageserver/Signatures.scala
Outdated
Show resolved
Hide resolved
language-server/src/dotty/tools/languageserver/DottyLanguageServer.scala
Outdated
Show resolved
Hide resolved
I've tried, but failed so far. I also tried to handle named arguments, but these are discarded by the typer when the application doesn't type check. I've tried keeping them, but it got hairy. It would be nice to get that to work, but I believe that this could be left as a future improvement. |
Duhemm
force-pushed
the
topic/ide-signature-help
branch
from
2d612ea to
d15a501
Compare
Sure, we should open an issue to not forget abou that. |
|
@smarter Do you have more comments or is this good to go? |
smarter
approved these changes
Nov 13, 2018
Duhemm
force-pushed
the
topic/ide-signature-help
branch
from
d15a501 to
9d32de2
Compare
This error message allows us to keep track of all the possible alternatives.
When the user starts writing a function application, the language client requests `textDocument/signatureHelp`. This is used to display help associated with the function application that is being written.
Co-Authored-By: Duhemm <[email protected]>
And address review comments.
Duhemm
force-pushed
the
topic/ide-signature-help
branch
from
9d32de2 to
25d436b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5394 and #5393 (only because a test exercises it)