Support show on Type[T] #5863
Merged
Support show on Type[T] #5863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
commented
Feb 6, 2019
liufengyun
force-pushed
the
add-show
branch
3 times, most recently
from
43cc22e to
34a24c9
Compare
|
@nicolasstucki I rebased and fixed all the conflicts. Could you have another look? Thanks. |
liufengyun
commented
Mar 20, 2019
Otherwise the typer will infer the type `wr.underlying.T`, which is not valid in source:
val x: wr.underlying.T = wr.underlying.get()
nicolasstucki
suggested changes
Mar 21, 2019
|
@nicolasstucki Could you have another look at it ? |
nicolasstucki
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support show on Type[T]