Fix #581: Add tests and adapt to named-base unapplySeq spec #5959
Conversation
| def isEmpty = xs == null | ||
| def get = xs |
There was a problem hiding this comment.
I'm guessing this change is needed because Array[T] only defines length apply and drop after implicit conversion to ArrayWrapper, which dotty doesn't perform in that case...
There was a problem hiding this comment.
Yes, the new Spec requires toSeq as well.
| case TripleBippy(3 :: Nil, 3.0, 'b', chars : _*) => "1: " + chars | ||
| case TripleBippy(5 :: Nil, 5.0, 'b' | 'B', chars : _*) => "2: " + chars | ||
| case TripleBippy(_, _, chars : _*) => "3: " + chars | ||
| case TripleBippy(3 :: Nil, 3.0, Bippy('b', chars : _*)) => "1: " + chars |
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
Currently Dotty does not support TripleBippy as it's written before. I agree this is not a proper fix. We need to decide whether or not to suppor the Scala2 behavior.
There was a problem hiding this comment.
Agreed. The spec is also inconsistent as it claims to support a super set of scalac patterns.
There was a problem hiding this comment.
Note that this test was changed in scala/scala@308ae2d#diff-f761b9d2bf9ec2f17bc00f552fc07314 when Scala 2.13 changed how name-based unapplySeq works: scala/scala#7068
There was a problem hiding this comment.
Thanks for the link @smarter 👍
|
Close in favor of #5989 |
Fix #581: Add tests and adapt to named-base unapplySeq spec