Skip to content

Avoid leaking ReflectImpl/KenelImpl in the compiler #6086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

Prviously we partally exposed the implementation of ReflectImpl by exposing KernelImpl in Reflect { val kernel: KernelImpl }.

@nicolasstucki nicolasstucki force-pushed the tasty-reflect-internal-avoid-leak branch from 6f71fb4 to 3d47314 Compare March 14, 2019 11:20
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 0d86d2b into scala:master Mar 14, 2019
@ghost ghost removed the stat:needs review label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants