Remove bindings from Inlined tree #6087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
remove-bindings-from-inlined-tree
branch
4 times, most recently
from
2e4383f to
ae555be
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
remove-bindings-from-inlined-tree
branch
3 times, most recently
from
da82756 to
e6f4452
Compare
nicolasstucki
commented
Mar 14, 2019
| // If the return type of an inline function is a singleton type of a parameter (like in `DottyPredef.the`) | ||
| // the expansion will be `{ val x = y; (x: x.type) }`. We ascribe the type to itself widening the | ||
| // local TermRef of the binding `{ val x = y; (x: y.type) }`. | ||
| tpd.Typed(finalExpansion, TypeTree(ctx.typer.avoidingType(finalExpansion, finalBindings))).withSpan(finalExpansion.span) |
There was a problem hiding this comment.
Here I had to add some extra logic to avoid type refs of the binding.
|
Will need rebase once #6066 is merged. |
nicolasstucki
force-pushed
the
remove-bindings-from-inlined-tree
branch
from
e6f4452 to
48c6a0e
Compare
|
Rebased |
|
What's the reason for this change ? |
|
Mostly remove unessesary complexity and some code duplication. |
odersky
approved these changes
Mar 17, 2019
odersky
reviewed
Mar 17, 2019
|
Indeed, we are missing some |
|
The positions do have the correct source/span, we already set them correctly. I will need to add some extra assertions on the |
nicolasstucki
force-pushed
the
remove-bindings-from-inlined-tree
branch
from
da6a5aa to
82e917d
Compare
nicolasstucki
force-pushed
the
remove-bindings-from-inlined-tree
branch
from
82e917d to
78807dc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.