Skip to content

Fix #9911: Remove Override flag from varargs forwarder when there is no forwarder to override #9927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

TheElectronWill
Copy link
Contributor

When the method overrides something but the forwarder doesn't, it is wrong to mark the latter as Override in all cases. This PR removes the flag when necessary.

@TheElectronWill TheElectronWill linked an issue Oct 1, 2020 that may be closed by this pull request
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheElectronWill TheElectronWill merged commit 119e1de into scala:master Oct 1, 2020
@TheElectronWill TheElectronWill deleted the fix/9911 branch October 1, 2020 21:28
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding varargs on override method fails to compile
3 participants