Skip to content

FIX: detect ill-pose sampling-strategy as a float #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

glemaitre
Copy link
Member

Fixes corner case with understandable errors. Crashing was happening when:

  • a ratio was given forcing to generate new-sample in under-sampling methods,
  • a ratio was given forcing to remove sample in over-sampling methods.

@pep8speaks
Copy link

pep8speaks commented Nov 16, 2018

Hello @glemaitre! Thanks for updating the PR.

Comment last updated on November 17, 2018 at 10:37 Hours UTC

@codecov
Copy link

codecov bot commented Nov 17, 2018

Codecov Report

Merging #507 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   98.86%   98.86%   +<.01%     
==========================================
  Files          82       82              
  Lines        5020     5023       +3     
==========================================
+ Hits         4963     4966       +3     
  Misses         57       57
Impacted Files Coverage Δ
imblearn/utils/tests/test_validation.py 100% <100%> (ø) ⬆️
imblearn/utils/_validation.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a8334...e539a59. Read the comment docs.

@glemaitre glemaitre merged commit 2b298dd into scikit-learn-contrib:master Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants