MNT remove fit_sample alias from base class

[glemaitre]

I think while deprecating fit_sample, we forgot to remove the alias from the base class.

[glemaitre]

ping @hayesall @chkoar

Does it seem OK with you.

[hayesall]

fit_sample is still mentioned in the readthedocs pages, but that's a separate issue. I say drop it.

[glemaitre]

Do you have an example because it should not be the case anymore :)

[chkoar]

fit_sample is still mentioned in the readthedocs pages, but that's a separate issue. I say drop it.

I would not drop it before solving #690.

[glemaitre]

Uhm yes this one. I have to give a look at it.

[hayesall]

Do you have an example because it should not be the case anymore :)

Here's one:

https://imbalanced-learn.readthedocs.io/en/stable/generated/imblearn.combine.SMOTEENN.html?highlight=fit_sample#imblearn.combine.SMOTEENN.fit_sample

Aliases for fit_sample were still generated on most methods.

[glemaitre]

We redirected the page since I think or at least the page is not accessible anymore?