Skip to content

Added fit_transform method to DataFrameMapper #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

dukebody
Copy link
Collaborator

From #152 rebased to last master.

Attempt to solve #150 by implementing the method fit_transform for DataFrameMapper.

My implementation follows the typical approach (e.g. in sklearn's DictVectorizer) of using a private _transform( ... , do_fit) method which optionally allows for fitting. Most of the changes are therefore due to some small refactoring. 3 new test are included, and a 3 existing tests with mock objects had to be adapted but are semantically unchanged.

@dukebody dukebody merged commit b6f6794 into master Aug 15, 2018
@dukebody dukebody deleted the SandroCasagrande-fit_transform branch August 15, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants