Skip to content

DOC: Revamp Building from Source on Windows #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2016
Merged

DOC: Revamp Building from Source on Windows #146

merged 1 commit into from
Mar 8, 2016

Conversation

gfyoung
Copy link
Contributor

@gfyoung gfyoung commented Feb 16, 2016

Addresses issue #145 by revamping / updating the documentation on building source from Windows to provide a more organized format as well as to reflect ongoing projects like Mingwpy that users should be aware of. Related to numpy issue #5479

@matthew-brett, @carlkl, @njsmith, @rgommers, @juliantaylor, @tkelman

used to build libraries ATLAS_, which at the moment is very Unix-oriented, although
that may be subject to change as we will discuss later on. If selected during installation,
Cygwin_ also makes available its own versions of the MinGW_ compilers (by the command
line option "-mno-cygwin" to gcc), which produce identical code. **There is no need to
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this option has not worked since gcc 3 and is an error since 4.5ish

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good to know. Fixed.

@gfyoung
Copy link
Contributor Author

gfyoung commented Feb 23, 2016

I have a first draft of the documentation put together now in this PR. I tried to be somewhat more general compared to the old version given how much active development is going on currently. If there is anything missing or inaccurate, please let me know!

###################

OpenBLAS_ is an optimized version of BLAS that is currently used in languages like Julia_ by default. Besides being
actively worked upon, it performs about as well as the Intel libraries discussed previously. Furthermore, it is also
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will install cygwin linked versions of openblas which work well with cygwin's python but probably not python.org native python

edit: this should be one line lower, sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries and fair point.

@gfyoung
Copy link
Contributor Author

gfyoung commented Feb 23, 2016

@tkelman : I made your suggested changes. If there is anything else that needs to be changed or is inaccurate, do let me know!

@gfyoung gfyoung changed the title WIP, DOC: Revamp Building from Source on Windows DOC: Revamp Building from Source on Windows Feb 24, 2016
NumPy and SciPy both support MSVC as the C/C++ compiler extension modules for the official
binary distribution of Python. However, make sure that you download the correct version!
For example, Python 2.7.x is compiled with Visual Studio 2008, and Python 3.5.1 is compiled
with Visual Studio 2015. Once you have found the appropriate version, visit this link `here <https://support.microsoft.com/en-gb/kb/2977003>`__

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This links to the 'Visual C++ redistributable package', which is not enough to build yourself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@gfyoung
Copy link
Contributor Author

gfyoung commented Mar 6, 2016

Does anyone else have anything to add to this at the moment? Otherwise, it seems like it can be merged.

also require their own Fortran compiler for these libraries to work. While it is possible to obtain
the libraries for free via their Community License (you can click `here <https://software.intel.com/sites/campaigns/nest/>`__
to learn and click `here <https://registrationcenter.intel.com/en/forms/?productid=2558&licensetype=2>`__ to register),
it does not come with their Fortran compiler, **ifort**, which is necessary for building both the NumPy and SciPy libraries with MKL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So on Windows it doesn't need icc, like it does on Linux? That's probably worth mentioning explicitly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No AFAICT. Based off the log, my builds use cl.exe from Visual Studio. I will add a comment to make it clear that icc is not strictly necessary.

@larsoner
Copy link
Member

larsoner commented Mar 7, 2016

Other than my nitpicks LGTM

@gfyoung
Copy link
Contributor Author

gfyoung commented Mar 8, 2016

@Eric89GXL : Updated PR with your comments. If no one else has anything to add, I think this is good to merge.

larsoner added a commit that referenced this pull request Mar 8, 2016
DOC: Revamp Building from Source on Windows
@larsoner larsoner merged commit 326c40b into scipy:master Mar 8, 2016
@larsoner
Copy link
Member

larsoner commented Mar 8, 2016

Thanks @gfyoung

@gfyoung gfyoung deleted the win_source_build branch March 8, 2016 21:29
@gfyoung
Copy link
Contributor Author

gfyoung commented Mar 8, 2016

@Eric89GXL : Thanks! Are you able to upload the changes to the website? I still see the original documentation.

@larsoner
Copy link
Member

larsoner commented Mar 9, 2016

I haven't done that before, so I'm not sure what the procedure is.

@gfyoung
Copy link
Contributor Author

gfyoung commented Mar 9, 2016

Not to worry. Somebody already did it. I believe the command is make upload, but you need ssh privileges, which is why I was asking if you could upload the changes since you can merge PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants