This repository was archived by the owner on Sep 3, 2022. It is now read-only.
feat(ids): check LocalStorage when cookies are not available #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates entity.js and user.js to dual write ids to localStorage and the cookies. This applies to userId, groupId and anonymousIds. Reads will check the cookie first, and fallback to the localStorage when a cookie is not available. When cookies are not available during reads, and localStorage is, we write the value to the cookie as well.
|
@f2prateek this PR is to merge our (already reviewed) localStorage changes to master, yes? |
|
Yes. |
nhi-nguyen
approved these changes
Mar 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates entity.js and user.js to dual write ids to localStorage and the cookies. This applies
to userId, groupId and anonymousIds. Reads will check the cookie first, and fallback to the
localStorage when a cookie is not available. When cookies are not available during reads, and
localStorage is, we write the value to the cookie as well.