Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Add --declaration back to build scripts and remove lib from .npmignore #178

Merged
merged 9 commits into from
Jul 30, 2020

Conversation

juliofarah
Copy link
Contributor

@juliofarah juliofarah commented Jul 29, 2020

Description

This PR:

  • Adds --declaration back to build scripts
  • Changes the way we expose types to remove module augmentation

Test plan

Testing completed successfully by checking that:

  • I can import AJS core and use its types
    Screen Shot 2020-07-30 at 11 14 45 AM

  • I can import interfaces from AJS core
    Screen Shot 2020-07-30 at 12 24 15 PM

  • AJS builds e2e and no regression is added:
    Screen Shot 2020-07-30 at 11 55 13 AM

Release plan

Releasing version 4.0.0-beta.1

@juliofarah juliofarah requested review from pooyaj and nettofarah July 29, 2020 23:36
@juliofarah juliofarah changed the title Add --declaration back to build scripts Add --declaration back to build scripts and remove lib from .npmignore Jul 30, 2020
@juliofarah juliofarah requested review from nettofarah, pooyaj and a team July 30, 2020 21:09
@juliofarah juliofarah merged commit 45256be into master Jul 30, 2020
@juliofarah juliofarah deleted the declaration branch July 30, 2020 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants