Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Replace PhantomJS with Headless Chrome for testing #182

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

bryanmikaelian
Copy link
Contributor

@bryanmikaelian bryanmikaelian commented Aug 12, 2020

This PR removes PhantomJS in favor of Headless Chrome. PhantomJS is no longer maintained and, as such, we cannot utilize ES6 features in our tests. This is part of a long-term goal to deprecate some third modules in favor of native functions (i.e. Object.assigns versus defaults)

For context, I simply followed the instructions here https://developers.google.com/web/updates/2017/06/headless-karma-mocha-chai

Test plan

Testing not required because this is a dev-only change.

Release plan

New version is not required because this is a dev-only change.

Checklist

  • Thorough explanation of the issue/solution, and a link to the related issue
  • CI tests are passing
  • Unit tests were written for any new code
  • Code coverage is at least maintained, or increased.

@pooyaj pooyaj self-requested a review August 12, 2020 18:39
Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryanmikaelian bryanmikaelian merged commit 7d9fdc9 into master Aug 12, 2020
@bryanmikaelian bryanmikaelian deleted the bryan/switch-from-phantom-to-headlesschrome branch August 12, 2020 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants