This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Replace PhantomJS with Headless Chrome for testing #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes PhantomJS in favor of Headless Chrome. PhantomJS is no longer maintained and, as such, we cannot utilize ES6 features in our tests. This is part of a long-term goal to deprecate some third modules in favor of native functions (i.e.
Object.assigns
versusdefaults
)For context, I simply followed the instructions here https://developers.google.com/web/updates/2017/06/headless-karma-mocha-chai
Test plan
Testing not required because this is a dev-only change.
Release plan
New version is not required because this is a dev-only change.
Checklist