This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Replace @ndhoule/includes with lodash.includes #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliofarah
approved these changes
Sep 16, 2020
williamgrosset
approved these changes
Sep 16, 2020
juliofarah
added a commit
that referenced
this pull request
Mar 19, 2021
This reverts commit c70c3af.
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
May 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
includes, provided by@ndhoule/includes, with the one provided bylodash.includes. Unfortunately, we cannot leverageString.prototype.includesbecause it is not available in any version of IE.Test plan
Testing completed successfully using e2e tests and unit tests. See examples below:
pagecall on a HTML document with a<link rel="canonical" href="http://taco:3000" />pagecall on a HTML document with a<link rel="canonical" href="http://taco:3000?cheese=false" />pagewith nocanonicalurlChecklist