This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Merge PR #184: adds types for Segment Integration Settings #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmikaelian
force-pushed
the
bryan/merge-184
branch
from
8d65a95 to
78f2fe2
Compare
juliofarah
approved these changes
Sep 22, 2020
|
Given the changes coming to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges #184, which focused on adding basic types for the Segment.io Integration. I tweaked the types, slightly, since we still don't have a great story on type definitions for all integrations.
Test plan
Testing not required because it is a dev-only change
Release plan
New version is not required because it is a dev-only change.
Checklist