Providing DEB #1831
Providing DEB #1831
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1831 +/- ##
==========================================
- Coverage 83.08% 83.00% -0.08%
==========================================
Files 284 284
Lines 48981 48877 -104
Branches 10324 10544 +220
==========================================
- Hits 40695 40572 -123
- Misses 7153 7163 +10
- Partials 1133 1142 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.github/workflows/package.yml
Outdated
| apt-get update | ||
| apt-get install -y --no-install-recommends cmake make g++ libpcap-dev |
There was a problem hiding this comment.
This step fails because we don't run it as sudo, which made me notice that this runs directly on the GitHub runner VM. Why not run it inside one of our containers like seladb/ubuntu2404? This image should already have these dependencies pre-installed
.github/workflows/package.yml
Outdated
| cd "${{ env.BUILD_DIR }}" | ||
| cmake .. | ||
| make -j$(nproc) | ||
| make install DESTDIR=$PWD/install-root |
There was a problem hiding this comment.
Instead of installing PcapPlusPlus here, maybe we can build the deb file, install it, and add another step to test that it works?
.github/workflows/package.yml
Outdated
| Version: ${{ github.event.release.tag_name }} | ||
| Section: libs | ||
| Architecture: amd64 | ||
| Maintainer: Bhaskar Bhar <[email protected]> |
There was a problem hiding this comment.
Can we add [email protected] as a maintainer?
.github/workflows/package.yml
Outdated
| - name: Upload DEB to release | ||
| uses: ncipollo/release-action@440c8c1cb0ed28b9f43e4d1d670870f059653174 # v1.16.0 | ||
| with: | ||
| draft: true | ||
| allowUpdates: true | ||
| updateOnlyUnreleased: true | ||
| artifacts: "${{ env.BUILD_DIR }}/pcapplusplus_${{ github.event.release.tag_name }}_amd64.deb" |
There was a problem hiding this comment.
Should this not have an if clause? The rest of the package CI's have the upload steps under if: github.ref_type == 'tag' clause?
|
@bhaskarbhar No worries about the flaws. That is why the reviews are for. Ty for the effort. :) |
|
@bhaskarbhar why did you close the PR? 🤔 |
As there were many flaws I thought to go through the package.yml and correct it rather than commiting everytime. Wanted to do a fresh PR with no flaws |
Added a new build-deb job to build a Debian package (.deb) for PcapPlusPlus on ubuntu-latest.
The job:
Issue: #1498