Skip to content

RecordsetEnumerating / RecordsetEnumerated Session events #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2024
Merged

RecordsetEnumerating / RecordsetEnumerated Session events #194

merged 2 commits into from
Mar 28, 2024

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Mar 28, 2024 •
edited
Loading

The event have EnumerationContext argument to distinguish interleaving enumerations

Also:

  • Fix compilation warnings in DataReader

ETW/LTTng provider would be more complicated

@SergeiPavlov SergeiPavlov requested a review from botinko March 28, 2024 20:16
botinko
botinko approved these changes Mar 28, 2024
View reviewed changes
Copy link

@botinko botinko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. I think it will be very useful for detecting ORM misuse.

@SergeiPavlov SergeiPavlov merged commit d9fb57c into master-servicetitan Mar 28, 2024
2 checks passed
@SergeiPavlov SergeiPavlov deleted the EnumerationEvent branch March 28, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botinko botinko botinko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeiPavlov @botinko