Skip to content

Optimize PacketFieldAccessor replace Rank checking by virtual function #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2024
Merged

Optimize PacketFieldAccessor replace Rank checking by virtual function #196

merged 1 commit into from
Mar 29, 2024

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Mar 29, 2024 •
edited
Loading

Branching overhead is bigger than virtual function call
As Rank is known at compile-time we need not to check it at runtime

@SergeiPavlov SergeiPavlov requested a review from botinko March 29, 2024 04:50
@SergeiPavlov SergeiPavlov merged commit 8582f50 into master-servicetitan Mar 29, 2024
2 checks passed
@SergeiPavlov SergeiPavlov deleted the VirtualGet branch March 29, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botinko botinko botinko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeiPavlov @botinko