Skip to content

Optimization: Replace CounterIncrementer & PositionUpdater array indexing by direct reference from Accessor #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 30, 2024
Merged

Optimization: Replace CounterIncrementer & PositionUpdater array indexing by direct reference from Accessor #198

merged 4 commits into from
Mar 30, 2024

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Mar 29, 2024 •
edited
Loading

This link is computed statically

Also:

  • Optimize TupleLayout.UpdateDescriptorPosition() to have direct access to Accessor's valueBitCount

@SergeiPavlov
Optimization: Replace CounterIncrementer & PositionUpdater array …
67f3e39 
…indexing by direct reference from Accessor
@SergeiPavlov SergeiPavlov requested a review from botinko March 29, 2024 06:20
@SergeiPavlov SergeiPavlov merged commit 73ca08e into master-servicetitan Mar 30, 2024
2 checks passed
@SergeiPavlov SergeiPavlov deleted the Incrementer branch March 30, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botinko botinko botinko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeiPavlov @botinko