Optimize PackedFieldDescriptor
to avoid Bit operations; DO_MAX_1000_COLUMNS
definition
#200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackedFieldDescriptorExtensions
short
andbyte
fields are faster thanShift
+AND
bit operationsThese bit operations are still used at Recordset's fields mapping time, which invoked less frequently than field access operations.
ushort Index
field is enough for ~30K fields in recordset because longest Value-types (Guid
,DateTimeOffset
,decimal
) eat 2long
sAlso:
Remove
[NonSerialized]
onAccessorIndex
field. It was a rudimentary from time whenAccessor
field was reference-typedAdd
DO_MAX_1000_COLUMNS
compilation constant to packPackedFieldDescriptorExtensions
into 4 bytes instead of 8. Arrays of this struct consume significant memory. I see:51,630 4,911,832 Xtensive.Tuples.Packed.PackedFieldDescriptor[]
in the last dumpIn this mode max # of recordset columns is ~1000