Skip to content

Optimize BuildMaterializer() #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2024
Merged

Optimize BuildMaterializer() #218

merged 1 commit into from
Apr 25, 2024

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Apr 24, 2024 •
edited
Loading

  • Use Method invoker
  • convert Materialization into struct
  • Avoid allocations in DisableSessionTags()
  • Avoid casting ArraySegments to IReadOnlyList because they are structs and have been boxed
  • Some refactoring to simplify code

@SergeiPavlov SergeiPavlov requested a review from botinko April 24, 2024 06:42
@SergeiPavlov SergeiPavlov changed the title Revert "Revert "Optimize BuildMaterializer()"" Optimize BuildMaterializer() Apr 24, 2024
@SergeiPavlov SergeiPavlov merged commit 82dce6f into master-servicetitan Apr 25, 2024
2 checks passed
@SergeiPavlov SergeiPavlov deleted the BuildMaterializer branch April 25, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botinko botinko botinko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeiPavlov @botinko