Skip to content

Optimization: Make Entity*EventArgs readonly struct records #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

SergeiPavlov
Copy link
Collaborator

This saves allocations
Every event handler uses its own, statically known event argument.
No need to inherit them from the same base

@SergeiPavlov SergeiPavlov requested a review from botinko April 24, 2024 22:16
@SergeiPavlov SergeiPavlov changed the title Optimization: Make EntityEventArgs readonly struct Optimization: Make Entity*EventArgs readonly struct records Apr 24, 2024
@SergeiPavlov SergeiPavlov merged commit 0bcdb38 into master-servicetitan Apr 25, 2024
2 checks passed
@SergeiPavlov SergeiPavlov deleted the EntityEventArgs branch April 25, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants