Skip to content

Optimization: Mark some internal classes as sealed to help optimizer #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Orm/Xtensive.Orm/Comparison/Internals/ValueTypeComparer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ public override void OnDeserialization(object sender)
Initialize();
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class BooleanAdvancedConverter :
internal sealed class BooleanAdvancedConverter :
StrictAdvancedConverterBase<bool>,
IAdvancedConverter<bool, byte>,
IAdvancedConverter<bool, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class ByteAdvancedConverter :
internal sealed class ByteAdvancedConverter :
StrictAdvancedConverterBase<byte>,
IAdvancedConverter<byte, sbyte>,
IAdvancedConverter<byte, short>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class ByteRoughAdvancedConverter :
internal sealed class ByteRoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<byte, bool>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class CharAdvancedConverter :
internal sealed class CharAdvancedConverter :
StrictAdvancedConverterBase<char>,
IAdvancedConverter<char, byte>,
IAdvancedConverter<char, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class ConvertingEnumerator<T1, T2> : IEnumerator<T2>
internal sealed class ConvertingEnumerator<T1, T2> : IEnumerator<T2>
{
private IEnumerator<T1> innerEnumerator;
private readonly Converter<T1, T2> converter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class DateTimeAdvancedConverter :
internal sealed class DateTimeAdvancedConverter :
StrictAdvancedConverterBase<DateTime>,
IAdvancedConverter<DateTime, byte>,
IAdvancedConverter<DateTime, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class DateTimeRoughAdvancedConverter :
internal sealed class DateTimeRoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<DateTime, float>,
IAdvancedConverter<DateTime, double>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class DecimalAdvancedConverter :
internal sealed class DecimalAdvancedConverter :
StrictAdvancedConverterBase<decimal>,
IAdvancedConverter<decimal, string>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class DecimalRoughAdvancedConverter :
internal sealed class DecimalRoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<decimal, bool>,
IAdvancedConverter<decimal, byte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class DoubleAdvancedConverter :
internal sealed class DoubleAdvancedConverter :
StrictAdvancedConverterBase<double>,
IAdvancedConverter<double, string>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class DoubleRoughAdvancedConverter :
internal sealed class DoubleRoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<double, bool>,
IAdvancedConverter<double, byte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class EnumAdvancedConverterFactory<TFrom> : IAdvancedConverterFactory<TFrom>
internal sealed class EnumAdvancedConverterFactory<TFrom> : IAdvancedConverterFactory<TFrom>
{
private readonly IAdvancedConverterProvider provider;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class EnumAdvancedConverter<TFrom, TTo, TUnderlyingFrom, TUnderlyingTo> : AdvancedConverterBase,
internal sealed class EnumAdvancedConverter<TFrom, TTo, TUnderlyingFrom, TUnderlyingTo> : AdvancedConverterBase,
IAdvancedConverter<TFrom, TTo>
where TFrom : struct
where TTo : struct
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class EnumAdvancedConverter<TFrom, TTo> : AdvancedConverterBase,
internal class EnumAdvancedConverter<TFrom, TTo> : AdvancedConverterBase,
IAdvancedConverter<TFrom, TTo>
where TFrom : struct
where TTo : struct
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class GuidAdvancedConverter :
internal sealed class GuidAdvancedConverter :
StrictAdvancedConverterBase<Guid>,
IAdvancedConverter<Guid, string>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class Int16AdvancedConverter :
internal sealed class Int16AdvancedConverter :
StrictAdvancedConverterBase<short>,
IAdvancedConverter<short, byte>,
IAdvancedConverter<short, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class Int16RoughAdvancedConverter :
internal sealed class Int16RoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<short, bool>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class Int32AdvancedConverter :
internal sealed class Int32AdvancedConverter :
StrictAdvancedConverterBase<int>,
IAdvancedConverter<int, byte>,
IAdvancedConverter<int, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class Int32RoughAdvancedConverter :
internal sealed class Int32RoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<int, bool>,
IAdvancedConverter<int, float>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class Int64AdvancedConverter :
internal sealed class Int64AdvancedConverter :
StrictAdvancedConverterBase<long>,
IAdvancedConverter<long, byte>,
IAdvancedConverter<long, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class Int64RoughAdvancedConverter:
internal sealed class Int64RoughAdvancedConverter:
RoughAdvancedConverterBase,
IAdvancedConverter<long, bool>,
IAdvancedConverter<long, float>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class NullableAdvancedConverterFactory<TFrom> : IAdvancedConverterFactory<TFrom>
internal sealed class NullableAdvancedConverterFactory<TFrom> : IAdvancedConverterFactory<TFrom>
{
private IAdvancedConverterProvider provider;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class NullableForwardAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom?, TFrom, TTo, TTo>
internal sealed class NullableForwardAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom?, TFrom, TTo, TTo>
where TFrom : struct
{
private static readonly bool toIsValueType = typeof (TTo).IsValueType;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class NullableNullableAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom?, TFrom, TTo?, TTo>
internal sealed class NullableNullableAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom?, TFrom, TTo?, TTo>
where TFrom : struct
where TTo : struct
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class NullableReverseAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom, TFrom, TTo?, TTo>
internal sealed class NullableReverseAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom, TFrom, TTo?, TTo>
where TTo : struct
{
/// <inheritdoc/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class ObjectAdvancedConverterFactory<TFrom> :
internal sealed class ObjectAdvancedConverterFactory<TFrom> :
IAdvancedConverterFactory<TFrom>
{
private readonly IAdvancedConverterProvider provider;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class ObjectToBaseAdvancedConverter<TFrom, TTo> : AdvancedConverterBase,
internal class ObjectToBaseAdvancedConverter<TFrom, TTo> : AdvancedConverterBase,
IAdvancedConverter<TFrom, TTo>
where TFrom : TTo
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class SByteRoughAdvancedConverter :
internal sealed class SByteRoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<sbyte, bool>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class SingleRoughAdvancedConverter :
internal sealed class SingleRoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<float, bool>,
IAdvancedConverter<float, byte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class StringAdvancedConverter :
internal sealed class StringAdvancedConverter :
StrictAdvancedConverterBase<string>
{
// Constructors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class StringRoughAdvancedConverter<T> :
internal sealed class StringRoughAdvancedConverter<T> :
RoughAdvancedConverterBase,
IAdvancedConverter<T, string>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class TimeSpanAdvancedConverter :
internal sealed class TimeSpanAdvancedConverter :
StrictAdvancedConverterBase<TimeSpan>,
IAdvancedConverter<TimeSpan, byte>,
IAdvancedConverter<TimeSpan, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class TimeSpanRoughAdvancedConverter :
internal sealed class TimeSpanRoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<TimeSpan, float>,
IAdvancedConverter<TimeSpan, double>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class TypeAdvancedConverter :
internal sealed class TypeAdvancedConverter :
StrictAdvancedConverterBase<Type>,
IAdvancedConverter<Type, string>,
IAdvancedConverter<string, Type>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class UInt16AdvancedConverter :
internal sealed class UInt16AdvancedConverter :
StrictAdvancedConverterBase<ushort>,
IAdvancedConverter<ushort, byte>,
IAdvancedConverter<ushort, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class UInt16RoughAdvancedConverter :
internal sealed class UInt16RoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<ushort, bool>
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class UInt32AdvancedConverter :
internal sealed class UInt32AdvancedConverter :
StrictAdvancedConverterBase<uint>,
IAdvancedConverter<uint, byte>,
IAdvancedConverter<uint, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class UInt32RoughAdvancedConverter :
internal sealed class UInt32RoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<uint, bool>,
IAdvancedConverter<uint, float>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class UInt64AdvancedConverter :
internal sealed class UInt64AdvancedConverter :
StrictAdvancedConverterBase<ulong>,
IAdvancedConverter<ulong, byte>,
IAdvancedConverter<ulong, sbyte>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Xtensive.Conversion
{
[Serializable]
internal class UInt64RoughAdvancedConverter :
internal sealed class UInt64RoughAdvancedConverter :
RoughAdvancedConverterBase,
IAdvancedConverter<ulong, bool>,
IAdvancedConverter<ulong, float>,
Expand Down
2 changes: 1 addition & 1 deletion Orm/Xtensive.Orm/Linq/ExpressionReplacer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace Xtensive.Linq
/// <summary>
/// Replaces references to one specific instance of an expression node with another node
/// </summary>
public class ExpressionReplacer : ExpressionVisitor
public sealed class ExpressionReplacer : ExpressionVisitor
{
private readonly Expression searchFor;
private readonly Expression replaceWith;
Expand Down
2 changes: 1 addition & 1 deletion Orm/Xtensive.Orm/Modelling/Validation/ValidationContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Xtensive.Modelling.Validation
/// Model validation context.
/// </summary>
[Serializable]
internal class ValidationContext : IContext<ValidationScope>
internal sealed class ValidationContext : IContext<ValidationScope>
{
private readonly HashSet<object> validated = new HashSet<object>();

Expand Down
Loading
Loading