Skip to content

fix protoc action using deprecated API #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 16, 2020
Merged

Conversation

kdorosh
Copy link

@kdorosh kdorosh commented Nov 16, 2020

update with changes from upstream

dependabot bot and others added 8 commits July 18, 2020 14:31
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <[email protected]>
The v1 branch will be updated on every release that increments the minor or patch version. Therefore, the use of this ref in workflows will result in the workflow automatically benefiting from ongoing improvements or fixes that don't cause a breaking change.

The use of the @master ref should not be encouraged, as it results in the use of unstable versions of the action.
…tions/core-1.2.6

Bump @actions/core from 1.0.0 to 1.2.6
…ash-4.17.19

Bump lodash from 4.17.15 to 4.17.19
@kdorosh
Copy link
Author

kdorosh commented Nov 16, 2020

tested against gloo. an original run with error:

https://github.com/solo-io/gloo/runs/1407733436

Error: The `add-path` command is deprecated and will be disabled on November 16th. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Now note the clean run:
https://github.com/solo-io/gloo/pull/3872/checks?check_run_id=1407801248

Tested on solo-io/gloo#3872

@kdorosh kdorosh marked this pull request as ready for review November 16, 2020 17:41
@kdorosh
Copy link
Author

kdorosh commented Nov 16, 2020

npm run test passes as well

@kdorosh kdorosh merged commit b8f1915 into master Nov 16, 2020
@kdorosh kdorosh deleted the fix_deprecated_protoc_min branch November 16, 2020 17:47
@kdorosh
Copy link
Author

kdorosh commented Nov 16, 2020

fyi, upstream has been fixed now. I recommend using that instead of our fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants