Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

make Cody and Code Search global navbar items one-click #63514

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

sqs
Copy link
Member

@sqs sqs commented Jun 27, 2024

I found it annoying that it took 2 clicks to go to Cody chat: click Cody in the global navbar, then click Web Chat. Users rarely will visit their dashboard, and that's associated with their user anyway, so it should be under their user. Same 2-click annoyance applies to going to Code Search.

Moves some other links:

  • Contexts, Search Jobs, Code Monitors, Notebooks --> moved to "Tools" global navbar item
  • Cody dashboard --> moved to user nav item (in top right)

image
image
image

Test plan

With minimize nav on and off, and with all states of dotcom and user-has-Cody-enabled, ensure matches expectations. The expectations are codified in the tests/

Changelog

  • Code Search and Cody now are one-click links in the global navbar. Other features are in the new "Tools" menu: search contexts, code monitors, search jobs, and notebooks. Your Cody dashboard is linked from your user menu (in the top right).

@sqs sqs requested review from taiyab and a team June 27, 2024 08:30
@cla-bot cla-bot bot added the cla-signed label Jun 27, 2024
Copy link
Contributor

@taiyab taiyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think it's great. I would love to do a full design cycle on all of Cody Web but I think it's best served in the rewrite.

A few things:

  • Did we remove Insights? I'm not seeing it as a top-level link.
  • We deprioritise exposure and access to editor extensions here quite severely. We probably wanna support it more in other places then: we should build in a nice CTA to those things in the main Cody Web chat view, at the moment there is a very missable "Editor extensions" link there which should get some love.
  • We can actually throw away the dashboard page once we add in a nice way to download extensions into the main Cody chat view (or actually repurpose into a "Usage" page (which is what it was meant to originally include but we didn't get to do any of the usage data/data vis stuff for it) once we pull through all that data on your Cody usage).
  • We could also add another link/pulldown to download one of the various extensions right into the Cody sidebar on the file view
  • Once we have a workable "Usage" page, we can add it in a subpage menu that belongs in the actual Cody Web page.

@sqs
Copy link
Member Author

sqs commented Jun 27, 2024

Overall, I think it's great. I would love to do a full design cycle on all of Cody Web but I think it's best served in the rewrite.

A few things:

  • Did we remove Insights? I'm not seeing it as a top-level link.

No, I just have it disabled in the instance I screenshotted on.

  • We deprioritise exposure and access to editor extensions here quite severely. We probably wanna support it more in other places then: we should build in a nice CTA to those things in the main Cody Web chat view, at the moment there is a very missable "Editor extensions" link there which should get some love.

Yeah, agreed.

  • We can actually throw away the dashboard page once we add in a nice way to download extensions into the main Cody chat view (or actually repurpose into a "Usage" page (which is what it was meant to originally include but we didn't get to do any of the usage data/data vis stuff for it) once we pull through all that data on your Cody usage).

Yep! Will merge these 2 pages.

  • We could also add another link/pulldown to download one of the various extensions right into the Cody sidebar on the file view

Great idea

  • Once we have a workable "Usage" page, we can add it in a subpage menu that belongs in the actual Cody Web page.

+1

@sqs sqs force-pushed the sqs/oneclick-nav branch 2 times, most recently from 171439c to 977aca1 Compare June 28, 2024 07:43
I found it annoying that it took 2 clicks to go to Cody chat: click **Cody** in the global navbar, then click **Web Chat**. Users rarely will visit their dashboard, and that's associated with their user anyway, so it should be under their user. Same 2-click annoyance applies to going to Code Search.

Moves some other links:

- Contexts, Search Jobs, Code Monitors, Notebooks --> moved to "Tools" global navbar item
- Cody dashboard --> moved to user nav item (in top right)
@sqs sqs force-pushed the sqs/oneclick-nav branch from 977aca1 to b7f96b4 Compare June 28, 2024 08:01
@sqs sqs merged commit c6bc1b5 into main Jun 28, 2024
10 checks passed
@sqs sqs deleted the sqs/oneclick-nav branch June 28, 2024 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants