There are a couple of ooooold pull requests for this library. How can these get merged into the master?

[PKeller34]

I use the SX1509 Qwiic adapter and found a compile time issue in the .cpp a couple years ago. I posted it here, hacked the trivial fix in my local copy way back then and promptly forgot about it. Just now I was compiling on a new machine with the latest library and PRESTO! the same error. Someone fixed it and issued a Pull request a couple years ago but it remains un-merged.

There is one other pull request outstanding with unrelated changes, github says all are able to be merged cleanly.

What would need to be done to get this merged in? Surely this is a question based on ignorance, yet I am ignorant.

[PaulZC]

Hi @PKeller34 ,

We've seen your posts on the Forum. Thanks for raising this.

Is PR #26 the important one for you? I see that #27 contains breaking changes. We'd need to think twice before merging that one.

Best,
Paul

[PKeller34]

PR 26 is the important one for me. I did look at PR 27 and am OK with that as well. It would not break anything of mine and I'm sympathetic to the naming style motivation to increase clarity even though that makes it a breaking change.

Thanks for putting up with my git-norance!

Best regards,

Perry

[PKeller34]

Could PR26 be merged without PR 27? I just had to reinstall the Arduino IDE, which undid my local hack to implement PR26.

Best regards,

Perry

[PaulZC]

Hi Perry,

Apologies for the delay...

Resolved in v3.0.6

Best wishes,
Paul