feat(tools): Add configurable exception handling for tool execution #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new configuration property `spring.ai.tools.throw-exception-on-error` that controls how tool execution errors are handled: - When false (default): errors are converted to messages and sent back to the AI model - When true: errors are thrown as exceptions for the caller to handle The implementation: - Adds the property to ToolCallingProperties - Updates ToolCallingAutoConfiguration to use the property - Improves error handling in MCP tool callbacks to use ToolExecutionException - Adds tests to verify both behaviors - Updates documentation with the new property Signed-off-by: Christian Tzolov <[email protected]>
|
LGTM. In the ToolCallingAutoConfiguration, we can perhaps use the builder method in |
|
Rebased and merged as 6f61fee. |
|
Back ported to 1.0.x via 3068c04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new configuration property
spring.ai.tools.throw-exception-on-errorthat controls how tool execution errors are handled:The implementation: