Skip to content

Rename setJobIncrementer to setJobInstanceIncrementer in JdbcJobInstanceDao #3929

Closed
@fmbenhassine

Description

@fmbenhassine

The DataFieldMaxValueIncrementer jobIncrementer field in JdbcJobInstanceDao is actually an incrementer for job instance IDs and not job IDs (which does not make much sense as there is no Job entity as part of the batch domain classes).

This setter is better renamed to setJobInstanceIncrementer (similar to jobExecutionIncrementer and stepExecutionIncrementer in other DAOs) to be more explicit about the entity IDs it is incrementing. The old setter should be deprecated in favour of the new one.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions