Skip to content

Add configuration properties for remaining Undertow server options #16278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add configuration properties for remaining Undertow server options #16278

wants to merge 1 commit into from

Conversation

rhamedy
Copy link
Contributor

@rhamedy rhamedy commented Mar 21, 2019

Added remaining Undertow's server configuration parameters. See the issue for ongoing discussion.

Fixes gh-16077

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 21, 2019
@wilkinsona wilkinsona changed the title Added remaining Undertow server configurations Add configuration properties for remaining Undertow server options Mar 25, 2019
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 25, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone Mar 25, 2019
@rhamedy
Added remaining Undertow server configurations
79bcf5c 
Added support for Undertow's server configurations namely max-parameters,
max-headers, max-cookies, allow-encoded-slash, decode-url, url-charset,
and always-set-keep-alive.

Fixes spring-projectsgh-16077
@rhamedy
Copy link
Contributor Author

rhamedy commented Mar 30, 2019

Resolved the conflict caused by 2.1.x release! Rebased, and resolved the conflicts 👍

@wilkinsona wilkinsona self-assigned this Apr 18, 2019
wilkinsona pushed a commit that referenced this pull request Apr 18, 2019
@rhamedy @wilkinsona
Add support for configuring remaining Undertow server options
186b1fa 
This commit adds support for configuring Undertow's server options that were previously
not configurable via application properties. The additions are the following:

- allow-encoded-slash
- always-set-keep-alive
- decode-url
- max-cookies
- max-headers
- max-parameters,
- url-charset

See gh-16278
wilkinsona added a commit that referenced this pull request Apr 18, 2019
@wilkinsona
Polish "Add support for configuring remaining Undertow server options"
ca1a666 
See gh-16278
@wilkinsona
Copy link
Member

wilkinsona commented Apr 18, 2019 •
edited
Loading

@rhamedy Thank you very much for making your first contribution to Spring Boot. I have merged to proposed changes in to master along with a polish commit. The polish addressed three main things:

  1. Updated the javadoc of the new properties to match the style of the rest of the codebase
  2. Switched to primitives and provided default values for the new properties where appropriate. This means that the default values are available in the configuration property metadata
  3. Improved the test coverage as I noticed that you'd accidentally configured the max header size using the max post size but our existing tests hadn't caught it

@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.2.0.M3 Apr 18, 2019
@rhamedy rhamedy deleted the gh-16077 branch April 20, 2019 06:10
@rhamedy
Copy link
Contributor Author

rhamedy commented Apr 20, 2019

@wilkinsona thanks for the polish and for describing your changes. The tests and changes look much better. The PR was definitely not final version and in my mind I thought there will be a review/feedback of some sort which would give me another opportunity to improve my changes. I am happy with my first contribution 🙂

@wilkinsona
Copy link
Member

Sorry for not giving you another opportunity to improve your changes. I hope you'll contribute again and, if you do, please feel free to remind us that you'd like another opportunity to improve things if needed rather than us polishing and merging. You could use GitHub's new support for draft pull requests to give us another reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.0.M3
Development

Successfully merging this pull request may close these issues.

Provide configuration properties for more of Undertow's server options
3 participants
@rhamedy @wilkinsona @spring-projects-issues