Skip to content

Allow Flyway or Liquibase to be auto-configured without a DataSource bean #16850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

L00kian
Copy link
Contributor

@L00kian L00kian commented May 14, 2019

LiquibaseAutoConfiguration and FlywayAutoConfiguration both require DataSource bean to be declared. However both configurations allow to explicitly define datasource properties which would create one anyway. #16849

…nfiguration.java and LiquibaseAutoConfiguration.java
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 14, 2019
@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label May 14, 2019
@philwebb philwebb added the for: merge-with-amendments Needs some changes when we merge label May 22, 2019
@philwebb
Copy link
Member

We might refine the condition to check for Datasource or the URL property when we merge.

@philwebb philwebb added type: bug A general bug type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels May 22, 2019
@philwebb philwebb added this to the 2.2.x milestone May 22, 2019
@wilkinsona wilkinsona changed the title Removed DataSource dependency Flyway and Liquibase auto configurations Allow Flyway or Liquibase to be auto-configured without a DataSource bean May 22, 2019
@wilkinsona wilkinsona self-assigned this May 29, 2019
@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.2.0.M4 May 29, 2019
wilkinsona added a commit that referenced this pull request May 29, 2019
@wilkinsona
Copy link
Member

Thank you very much for making your first contribution to Spring Boot, @L00kian. The changes have now been merged into master with some modifications. As suggested above by @philwebb, we now look for either a DataSource or a spring.(flyway|liquibase).url property. The auto-configuration backs off is neither is available. This reduces the scope of the changes as the custom exceptions and failure analyzers are no longer required. You can see combined effect of your changes and the modifications in the diff of the merge commit.

@L00kian L00kian deleted the flyway-liquibase-no-ds branch May 29, 2019 10:15
@L00kian
Copy link
Contributor Author

L00kian commented May 29, 2019

@wilkinsona Thank you for accepting it. I was glad to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants