Define the classloader for FluentConfiguration #16947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Alan-Gomes Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Alan-Gomes Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
|
Thanks for the PR. I think ideally we should also add some tests for this. |
|
I wrote a test to verify this configuration, it should be ok now. |
wilkinsona
pushed a commit
that referenced
this pull request
May 29, 2019
wilkinsona
added a commit
that referenced
this pull request
May 29, 2019
|
@Alan-Gomes Thanks very much for making your first contribution to Spring Boot. I have merged your changes into master along with a polish commit. The primary reason for the polish was to move away from using a mock ClassLoader as it caused the test to fail due to the mock not being able to find any migration scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The out of the box support for Flyway currently does not work with a custom class loader defined in
ResourceLoader. Without this compatibility, Flyway will not be able to load scripts inside theresourcesfolder. I experienced this issue when developing a custom starter which runs inside a personalized class loader.