Skip to content

Restore custom favicon documentation #31224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Restore custom favicon documentation #31224

wants to merge 1 commit into from

Conversation

ittays
Copy link

@ittays ittays commented May 31, 2022

This PR restores the favicon documentation mistakenly removed in 5fceb9d.

The 5fceb9d commit did not change the default behavior at all, just opened the option to define non-default favicon.ico files, such as "/favicon.ico", "/favicon.png" and "/icons/icon-48x48.png".

What it did change is overriding the lookup for the favicon.ico from anywhere in the resources (/**/) to a sub directory (/*/). Thus I changed the doc wording a bit from

Spring Boot looks for a favicon.ico

to

Spring Boot checks for a favicon.ico

This PR closes gh-31026

Restore custom favicon documentation
053c9d8 
Documentation mistakenly removed in 5fceb9d.

Closes spring-projectsgh-31026
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 31, 2022
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels May 31, 2022
@philwebb philwebb added this to the 2.6.x milestone May 31, 2022
@philwebb philwebb mentioned this pull request May 31, 2022
Closed
@ittays
Copy link
Author

ittays commented Jun 1, 2022

Thanks @philwebb for handling this.
As it's my first commit here, please let me know of I took the correct target branch (main), and if any further work is needed from my side to conclude this PR.

@snicoll snicoll self-assigned this Jun 13, 2022
@snicoll snicoll modified the milestones: 2.6.x, 2.6.9 Jun 13, 2022
@snicoll snicoll mentioned this pull request Jun 13, 2022
Closed
snicoll pushed a commit that referenced this pull request Jun 13, 2022
@snicoll
Restore Custom Favicon section in the reference guide
e05363f 
The section about favicon was mistakenly removed in 5fceb9d and this
commit reinstates it.

See gh-31224
@snicoll snicoll closed this in 3f1af9b Jun 13, 2022
@snicoll
Copy link
Member

snicoll commented Jun 13, 2022

@ittays thank you for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.6.9
Development

Successfully merging this pull request may close these issues.

Custom Favicon missing in the documentation
4 participants
@ittays @snicoll @philwebb @spring-projects-issues