Skip to content

PageableHandlerMethodArgumentResolverSupport still uses page, size as the default parameter names #3120

Open
@agongi

Description

@agongi

According to #2882, AbstractPageRequest has been changed field names to

  • size -> pageSize
  • page -> pageNumber

This change has impact to any Page<?> response. but https://github.com/spring-projects/spring-data-commons/blob/main/src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolverSupport.java still uses

  • private static final String DEFAULT_PAGE_PARAMETER = "page";
  • private static final String DEFAULT_SIZE_PARAMETER = "size";

as a default params name, this may cause inconsistency.

Parameter names are changable using setPageParameterName, getPageParameterName but also be great default value is changed to

  • private static final String DEFAULT_PAGE_PARAMETER = "pageNumber";
  • private static final String DEFAULT_SIZE_PARAMETER = "pageSize";

as AbstractPageRequest was already been changed.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions