DATACMNS-1208 - fixed hasPersistentEntityFor() vs getPersistentEntity… #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ForClass() inconsistency Making call to AbstractMappingContext.getPersistentEntityForClass() created an entry in persistentEntities map for every type for which shouldCreatePersistentEntity() == false. This was causing hasPersistentEntityFor() to falsely return true after such call. This was fixed by not keeping Optionals in persistentEntities as this seem to serve no purpose.
odrotbohm
added a commit
that referenced
this pull request
Nov 14, 2017
…properly considers cached absence. AbstractMappingContext.hasPersistentEntityFor(…) now also properly consideres the empty Optional as non-presence as that is held to allow to distinguish between a type completely unkown to the context, or already known but not considered a persistent entity. Related pull request: #258.
odrotbohm
added a commit
that referenced
this pull request
Nov 14, 2017
…properly considers cached absence. AbstractMappingContext.hasPersistentEntityFor(…) now also properly consideres the empty Optional as non-presence as that is held to allow to distinguish between a type completely unkown to the context, or already known but not considered a persistent entity. Related pull request: #258.
|
Fixed with a less invasive change. See the ticket for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ForClass() inconsistency
Making call to AbstractMappingContext.getPersistentEntityForClass() created an entry in persistentEntities map for every type for which shouldCreatePersistentEntity() == false. This was causing hasPersistentEntityFor() to falsely return true after such call. This was fixed by not keeping Optionals in persistentEntities as this seem to serve no purpose.