DATACMNS-1261 - Apply Java 8 Functional types and Lambdas to simplify… #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxblum
force-pushed
the
DATACMNS-1261
branch
3 times, most recently
from
6b27587 to
4fd7e41
Compare
… parsing logic in Repository configuration. Additionally, fix up Exception error messages and edit Javadoc.
jxblum
force-pushed
the
DATACMNS-1261
branch
from
4fd7e41 to
e4a84df
Compare
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
mp911de
requested changes
Jul 17, 2020
| throw new IllegalArgumentException( | ||
| String.format("Could not obtain required bean class name from BeanDefinition!", beanDefinition)); | ||
| } | ||
| Assert.notNull(result, String.format("Could not obtain required bean class name from BeanDefinition [%s]!", |
There was a problem hiding this comment.
This change has performance impact as String.format(…) is invoked regardless of whether it's required to. We should either stick with the previous variant or use a message supplier. There are also occurrences of similar changes.
| * @see java.lang.Iterable | ||
| * @since 2.1.0 | ||
| */ | ||
| public abstract class IterableUtils { |
There was a problem hiding this comment.
Not sure that Spring Data is the best place for such a utility. I'd suggest to move it to Spring Framework.
|
Closing this pull request since there was no update since quite a while. We can reopen it if we want to revive it. |
mp911de
added
the
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… parsing logic in Repository configuration.