Javadoc of code repackaged in 4.4.0 snapshots states that it has been available since earlier major versions

[wilkinsona]

For example, org.springframework.data.elasticsearch.backend.elasticsearch7.client.reactive. ReactiveElasticsearchClient is documented as @since 3.2 but it's new in 5.0.

[sothawo]

It's not new, it's existing code moved to a different package. Should that change the @since?

[wilkinsona]

If someone looks for org.springframework.data.elasticsearch.backend.elasticsearch7.client.reactive. ReactiveElasticsearchClient in 3.2 it won't be there, but the javadoc currently tells them that it will be. From a compatibility perspective, all of the repackaged code is new in 5.0 and I think each class's @since javadoc should reflect that.

Here's an example from Spring Boot where DispatcherServletAutoConfiguration changed package in 2.0:

• https://github.com/spring-projects/spring-boot/blob/1.5.x/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/DispatcherServletAutoConfiguration.java
• https://github.com/spring-projects/spring-boot/blob/2.0.x/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/DispatcherServletAutoConfiguration.java

Note that the @since changed from 1.0.0 to 2.0.0 as a result of the repackaging.

[sothawo]

ok, I'll change that to be consistent to what Spring does.

[sothawo]

nitpick: the change will be from 4.4 on 😜