Docuement id is not generated as expected when upgrade to Spring Boot 3.2.x

[hantsy]

I tried to update my example projects to the latest Spring 6.1.x, Spring Boot 3.2 and Java 21.

The Spring Data ElasticSearch example failed, the example source codes is here, https://github.com/hantsy/spring6-sandbox/tree/master/boot-data-elasticsearch

@Document(indexName = "products")
public record Product(@Id String id, String name, BigDecimal price) {
}

And test is like :

@DataElasticsearchTest
@Testcontainers
@Slf4j
public class ElasticsearchIntegrationTests {

    @Container
    @ServiceConnection
    public static ElasticsearchContainer ES_CONTAINER = new ElasticsearchContainer("docker.elastic.co/elasticsearch/elasticsearch:7.17.9");

    @Autowired
    private ProductRepository productRepository;

    @Test
    void testDatabaseIsRunning() {
        assertThat(ES_CONTAINER.isRunning()).isTrue();
    }

    @Test
    public void testProductRepository() {
        var product = productRepository.save(new Product(null, "test", BigDecimal.ONE));
        assertThat(product).isNotNull();
        assertThat(product.id()).isNotNull();

        productRepository.findById(product.id()).ifPresent(
            p -> {
                log.debug("found product by id: {}", p);
                assertThat(p.name()).isEqualTo("test");
            }
        );
    }
}

And got the following error.

2023-09-24T20:38:24.405+08:00 DEBUG 17172 --- [           main] .c.s.DirtiesContextTestExecutionListener : After test method: class [ElasticsearchIntegrationTests], method [testProductRepository], class annotated with @DirtiesContext [false] with mode [null], method annotated with @DirtiesContext [false] with mode [null]

java.lang.AssertionError: 
Expecting actual not to be null

	at com.example.demo.ElasticsearchIntegrationTests.testProductRepository(ElasticsearchIntegrationTests.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

It means the entity id is not filled as expected.

This example worked with Spring Boot 3.1.x and Java 17.

[sothawo]

Please provide a complete runnable example showing this behaviour.

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[sothawo]

I just had another look at the repository you linked. If you want us to look into this, provide a standalone runnable example, not a GitHub repository containing lots of different spring data subdirectories which are irrelevant for this problem.

The I don't find any code configuring the Spring Data Elasticsearch client. The test is starting an Elasticsearch TestContainer in version 7.17.9, Spring Data Elasticsearch 5.2 is built against Elasticsearch 8, so this might only work with Elasticsearch compatibility headers set, but I do not see that they are set anywhere.

When changing to new versions you should adapt your code/configurations to changes in the used libraries.

[hantsy]

boot-data-elasticsearch.zip

Updated to ES8, and run the test will get the failed message.

[sothawo]

I tried to run the test from the zip file

1. The mvnw file has Windows linebreaks and cannot be run on Linux/macOs without fixing it.
2. I had to uncomment the commented out code in the setup exposing the @DynamicPropertySource
3. The whole Spring application startup fails on the first attempt of accessing the Elasticsearch server, it doesn't even get to a point where a test is executed.
4. The reason for this is that the Elasticsearch server running in testcontainers is starting a HTTPS endpoint, which on your side is not configured.

There's a great article by Alex Reelsen about Elasticsearch 8 and TestContainers (https://spinscale.de/posts/2022-02-17-running-elasticsearch-8-with-testcontainers.html)

This whole setup is no Spring Data Elasticsearch problem anyway, it is a test setup / Spring Boot configuration problem.

The official way to configure Spring Data Elasticsearch is found in the documentation (https://docs.spring.io/spring-data/elasticsearch/docs/current/reference/html/#elasticsearch.clients). If you rely on Spring Boot autoconfiguration then that is a Spring Boot problem and this is the wrong place to address it, check https://github.com/spring-projects/spring-boot for that.

[hantsy]

Maybe it is an autoconfiguration issue of Spring boot testcontainers, it was working in Spring Boot 3.1.

[hantsy]

The purpose of this sample project is testing spring-boot-testcontainers to replace the manual testcontainers config which requires @DynamicPropertySource.