Delete by Predicate [DATAJPA-954]

[spring-projects-issues]

Lovro Pandžić opened DATAJPA-954 and commented

Add support for delete by Predicate (Querydsl)

---

Issue Links:

• DATACMNS-553 QueryDslPredicateExecutor delete
  ("depends on")

Referenced from: pull request #184

1 votes, 4 watchers

[spring-projects-issues]

Nikita Mishchenko commented

Could you provide(specify) more info about this idea?

[spring-projects-issues]

Lovro Pandžić commented

Currently it is not possible to specify delete in statically typed way with Spring Data JPA and this is a pretty common use case.

Example usage:

userRepository.deleteWhere(user.surname.eq("Smith"));

[spring-projects-issues]

Nikita Mishchenko commented

Should work as expected

[spring-projects-issues]

Jens Schauder commented

The PR references a org.springframework.data.querydsl.QueryDslPredicateModifyingExecutor which doesn't exist. I'm not sure if it ever was part of another PR but I couldn't find it.

A generic delete method of this kind, i.e. one that is part of an interface in SD Commons should

• trigger events for the entities deleted which means: It should load the entities and then iterate over those to delete them
• a batch version similar to JpaRepository.deleteInBatch() would be possible in an JPA specific interface. Such an implementation should then take care of entities in the cache which probably means: flushing, clearing the persistence context, then deleting.

As a work around one could always use the existing find methods and delete the result.

This is nothing we would currently invest time in, but if someone wants to create a new PR I'm willing to merge it

[spring-projects-issues]

Lovro Pandžić commented

Can you please explain why there was no response to this issue and PR by maintainers for over 2 years?

[spring-projects-issues]

Jens Schauder commented

Lovro Pandžić Because no one found time to do it.
What else do you think would be the reason?

[spring-projects-issues]

Lovro Pandžić commented

I suspected as much but I wanted confirmation. I find it concerning that someone invested their private time into a PR and then it's just discarded like this 2 years after.

Feel free to close this issue as I have developed an alternative for my case quite some time ago