Invalid error message in case of null id in the findById method

[mhewedy]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general ideal-for-contribution issues. Thanks!

Problem

The error message in KeyValueTemplate.findById(…) reports a message that doestn't match the intended action:

spring-data-keyvalue/src/main/java/org/springframework/data/keyvalue/core/KeyValueTemplate.java

Line 259 in c84c309

Assert.notNull(id, "Id for object to be inserted must not be null!");

Solution

Update the exception message so it no longer talks about inserted objects but reports a more appropriate message or aligns with the general convention … must not be null!.

Steps to Fix

• Claim this issue with a comment below and ask any clarifying questions you need
• Set up a repository locally following the Contributing Guidelines
• Try to fix the issue following the steps above
• Commit your changes and start a pull request.

[AbassAdeyemi]

I would love to claim this issue.

[mp911de]

Great, @AbassAdeyemi the issue is yours and please let us know if you have any questions.

[mp911de]

Fixed via #345.