DATAREDIS-711 - Emit Lua array responses as List. #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now emit array responses from Lua script execution as complete List instead of emitting the individual elements through the Publisher. Lua scripts may return nil (null) elements that would be not emitted through a Publisher. Skipping null values would garble up the response – and in several cases, the response array is required as List. Emitting the whole List aligns the response to the signatures imposed by generics and aligns the behavior with the imperative API.
Use the configured value serializer for Lua argument serialization.
Strenghen non-null requirements when obtaining the native connection from LettuceReactiveRedisConnection. Guard close against multiple calls.
christophstrobl
pushed a commit
that referenced
this pull request
Oct 11, 2017
We now emit array responses from Lua script execution as complete List instead of emitting the individual elements through the Publisher. Lua scripts may return nil (null) elements that would be not emitted through a Publisher. Skipping null values would garble up the response – and in several cases, the response array is required as List. Emitting the whole List aligns the response to the signatures imposed by generics and aligns the behavior with the imperative API. Original Pull Request: #282
christophstrobl
pushed a commit
that referenced
this pull request
Oct 11, 2017
Strengthen non-null requirements when obtaining the native connection from LettuceReactiveRedisConnection. Guard close against multiple calls and use concatMap instead of flatMap to retain publisher sequence. Original Pull Request: #282
christophstrobl
added a commit
that referenced
this pull request
Oct 11, 2017
Retain publisher sequence by using concatMap, remove trailing whitespace, flush script cache in tests. Original Pull Request: #282
christophstrobl
pushed a commit
that referenced
this pull request
Oct 12, 2017
We now emit array responses from Lua script execution as complete List instead of emitting the individual elements through the Publisher. Lua scripts may return nil (null) elements that would be not emitted through a Publisher. Skipping null values would garble up the response – and in several cases, the response array is required as List. Emitting the whole List aligns the response to the signatures imposed by generics and aligns the behavior with the imperative API. Original Pull Request: #282
christophstrobl
pushed a commit
that referenced
this pull request
Oct 12, 2017
Strengthen non-null requirements when obtaining the native connection from LettuceReactiveRedisConnection. Guard close against multiple calls and use concatMap instead of flatMap to retain publisher sequence. Original Pull Request: #282
christophstrobl
added a commit
that referenced
this pull request
Oct 12, 2017
Retain publisher sequence by using concatMap, remove trailing whitespace, flush script cache in tests. Original Pull Request: #282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now emit array responses from Lua script execution as complete
Listinstead of emitting the individual elements through thePublisher.Lua scripts may return nil (
null) elements that would be not emitted through aPublisher. Skippingnullvalues would garble up the response – and in several cases, the response array is required asList. Emitting the wholeListaligns the response to the signatures imposed by generics and aligns the behavior with the imperative API.Fix value serialization by using the configured value serializer when serializing Lua script arguments.
Related ticket: DATAREDIS-711.