DATAREDIS-580 - Support Master/Slave connections with ReadFrom settings using Lettuce. #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
force-pushed
the
issue/DATAREDIS-580
branch
from
09509c2 to
3a5894a
Compare
…gs using Lettuce. We now allow configuration of ReadFrom settings using the Lettuce driver to enable slave reads. If ReadFrom is configured, we opt-in to Master/Slave connections instead of plain connections. Master/Slave connections route commands to the configured type of node depending on whether the command is a read or write command. LettuceClientConfiguration configuration = LettuceClientConfiguration.builder().readFrom(ReadFrom.SLAVE).build(); ReadFrom is available for: * Static Master/Slave Redis without Redis Sentinel * Sentinel-Managed Master/Slave Redis * Redis Cluster ReadFrom is not configured for Pub/Sub connections or connections to the actual Sentinel servers.
…lass. Reuse guards to make sure we can use a slave server.
Fix tests not closing connections properly. Remove usage of Optional in constructors, avoid recreating DirectFieldAccessor on every getConnection call and update documentation.
christophstrobl
force-pushed
the
issue/DATAREDIS-580
branch
from
3a5894a to
c3f7a59
Compare
christophstrobl
pushed a commit
that referenced
this pull request
Nov 21, 2017
…gs using Lettuce. We now allow configuration of ReadFrom settings using the Lettuce driver to enable slave reads. If ReadFrom is configured, we opt-in to Master/Slave connections instead of plain connections. Master/Slave connections route commands to the configured type of node depending on whether the command is a read or write command. LettuceClientConfiguration configuration = LettuceClientConfiguration.builder().readFrom(ReadFrom.SLAVE).build(); ReadFrom is available for: * Static Master/Slave Redis without Redis Sentinel * Sentinel-Managed Master/Slave Redis * Redis Cluster ReadFrom is not configured for Pub/Sub connections or connections to the actual Sentinel servers. Original Pull Request: #287
christophstrobl
added a commit
that referenced
this pull request
Nov 21, 2017
Fix tests not closing connections properly. Remove usage of Optional in constructors, avoid recreating DirectFieldAccessor on every getConnection call and update documentation. Original Pull Request: #287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow configuration of ReadFrom settings using the Lettuce driver to enable slave reads. If
ReadFromis configured, we opt-in to Master/Slave connections instead of plain connections. Master/Slave connections route commands to the configured type of node depending on whether the command is a read or write command.ReadFrom is available for:
ReadFrom is not configured for Pub/Sub connections or connections to the actual Sentinel servers.
Related ticket: DATAREDIS-580.