Make StreamListener read batch messages at once #3138
+21
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: Yongha Kwon <[email protected]>
Signed-off-by: Yongha Kwon <[email protected]>
mp911de
requested changes
Apr 25, 2025
| @@ -33,5 +36,5 @@ public interface StreamListener<K, V extends Record<K, ?>> { | |||
| * | |||
| * @param message never {@literal null}. | |||
| */ | |||
| void onMessage(V message); | |||
| void onMessage(List<V> message); | |||
There was a problem hiding this comment.
That won't work as this is a breaking change.
| pollState.updateReadOffset(raw.getId().getValue()); | ||
| V record = convertRecord(raw); | ||
| listener.onMessage(record); | ||
| messages.add(record); |
There was a problem hiding this comment.
Batching introduces an error category of message loss if one of the messages causes an exception. In such a case, the read offset has been updated but the message was never delivered to a listener.
There was a problem hiding this comment.
Thanks for the feedback. I will revise the PR based on your suggestions.
I'll try implementing a separate class called StreamBatchListener to handle batch processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves spring-projects/spring-data-redis#3078
This pull request implements support for batch message consumption in StreamListener,
allowing it to receive and process multiple messages at once.