EventListener in a Request scoped bean fails context initialization [SPR-13681]

[spring-projects-issues]

Abhijit Sarkar opened SPR-13681 and commented

I've a request scoped bean:

@Component
@Scope(value = SCOPE_REQUEST, proxyMode = TARGET_CLASS)
public class RequestContextImpl implements RequestContext, Cloneable {
  @EventListener
  void setServiceId(ServiceIdFoundEvent event) {
    this.serviceId = event.getServiceId();
  }
}

public class ServiceIdFoundEvent extends ApplicationEvent {
  private static final long serialVersionUID = -4841984309730357349L;

  public ServiceIdFoundEvent(Integer serviceId) {
    super(serviceId);
  }

  public int getServiceId() {
    return (Integer) source;
  }

  // equals and hashCode
}

that fails the context initialization with the following error message:

INFO] [talledLocalContainer] 14:56:54.809 [localhost-startStop-1] ERROR o.s.web.context.ContextLoader - Context initialization failed
[INFO] [talledLocalContainer] org.springframework.beans.factory.BeanInitializationException: Failed to process @EventListener annotation on bean with name 'requestContextImpl'; nested exception is java.lang.IllegalStateException: @EventListener method 'setServiceId' found on bean target class 'RequestContextImpl', but not found in any interface(s) for bean JDK proxy. Either pull the method up to an interface or switch to subclass (CGLIB) proxies by setting proxy-target-class/proxyTargetClass attribute to 'true'
[INFO] [talledLocalContainer] 	at org.springframework.context.event.EventListenerMethodProcessor.afterSingletonsInstantiated(EventListenerMethodProcessor.java:95) ~[spring-context-4.2.0.RELEASE.jar:4.2.0.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:792) ~[spring-beans-4.2.0.RELEASE.jar:4.2.0.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:834) ~[spring-context-4.2.0.RELEASE.jar:4.2.0.RELEASE]

Not only the message is wrong (it asks for CGLIB proxy which is ScopedProxyMode.TARGET_CLASS, it appears from the logs that the EventListenerMethodProcessor is trying to process the bean definition as a singleton.

---

Affects: 4.2 GA

Issue Links:

• EventListenerMethodProcessor unconditionally instantiates certain beans, leading to BeanCreationException during deployment [SPR-13526] #18103 EventListenerMethodProcessor unconditionally instantiates certain beans, leading to BeanCreationException during deployment
• EventListenerMethodProcessor resolves classes of lazy beans causing NoClassDefFoundError [SPR-13712] #17619 EventListenerMethodProcessor resolves classes of lazy beans causing NoClassDefFoundError

Referenced from: commits 24e4f56

[spring-projects-issues]

Juergen Hoeller commented

This looks like a duplicate of #18103 which got fixed in 4.2.2 already. Please give it a try, or try a 4.2.3.BUILD-SNAPSHOT right away since 4.2.3 is about to be released in a few days...

Juergen

[spring-projects-issues]

Abhijit Sarkar commented

Upgrade to 4.2.2 still fails, only with a different text. It appears that instead of delaying registration of event listeners for request scoped beans, it is trying to do so at startup. This is not a new issue either as reported in this SO thread.

INFO] [talledLocalContainer] org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'scopedTarget.requestContextImpl': Scope 'request' is not active for the current thread; consider defining a scoped proxy for this bean if you intend to refer to it from a singleton; nested exception is java.lang.IllegalStateException: No thread-bound request found: Are you referring to request attributes outside of an actual web request, or processing a request outside of the originally receiving thread? If you are actually operating within a web request and still receive this message, your code is probably running outside of DispatcherServlet/DispatcherPortlet: In this case, use RequestContextListener or RequestContextFilter to expose the current request.
[INFO] [talledLocalContainer] 	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:354) ~[spring-beans-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:196) ~[spring-beans-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.aop.target.SimpleBeanTargetSource.getTarget(SimpleBeanTargetSource.java:35) ~[spring-aop-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.getTarget(CglibAopProxy.java:685) ~[spring-aop-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:636) ~[spring-aop-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at com.nuance.dcs.transformengine.core.web.RequestContextImpl$$EnhancerBySpringCGLIB$$571b09c9.setDeviceInfo(<generated>) ~[spring-core-4.2.2.RELEASE.jar:2.0.0-SNAPSHOT]
[INFO] [talledLocalContainer] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_45]
[INFO] [talledLocalContainer] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_45]
[INFO] [talledLocalContainer] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_45]
[INFO] [talledLocalContainer] 	at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_45]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.ApplicationListenerMethodAdapter.doInvoke(ApplicationListenerMethodAdapter.java:227) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.ApplicationListenerMethodAdapter.processEvent(ApplicationListenerMethodAdapter.java:144) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.ApplicationListenerMethodAdapter.onApplicationEvent(ApplicationListenerMethodAdapter.java:106) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:163) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:136) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:380) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:347) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.ApplicationListenerMethodAdapter.publishEvent(ApplicationListenerMethodAdapter.java:198) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.ApplicationListenerMethodAdapter.handleResult(ApplicationListenerMethodAdapter.java:191) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.ApplicationListenerMethodAdapter.processEvent(ApplicationListenerMethodAdapter.java:146) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.ApplicationListenerMethodAdapter.onApplicationEvent(ApplicationListenerMethodAdapter.java:106) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:163) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:136) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:380) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:334) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:851) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:540) ~[spring-context-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:446) ~[spring-web-4.2.2.RELEASE.jar:4.2.2.RELEASE]
[INFO] [talledLocalContainer] 	at org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:328) ~[spring-web-4.2.2.RELEASE.jar:4.2.2.RELEASE]

[spring-projects-issues]

Juergen Hoeller commented

It seems that it is failing during the publication of Spring's own ContextRefreshedEvent there, which it is trying to invoke your event listener method for - which is clearly typed for a different event. I'll have a look whether we're initializing the listener bean too early there, i.e. before narrowing the set of applicable listeners for the given event type.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

I can't reproduce this against 4.2.3, actually, considering it as resolved in that version. I will add my test case for it to 4.2.4's test suite.

Could please verify whether it still fails against 4.2.3 (as released ~10 days ago) for you? If yes, please provide a minimal test case that reproduces it and reopen this issue once again...

Juergen