Description
Christian Nelson opened SPR-1274 and commented
If the map key contains nested brackets, the key is not properly extracted from the string by BeanWrapperImpl.getPropertyNameTokens(String propertyName).
For example, consider these 'paths':
- "entries[some text[abc]]", key = "some text[abc" (missing ])
- "entries['some text[abc]']", key = "'some text[abc" (missing ]')
- "entries["some text[abc]"]", key = ""some text[abc" (missing ]")
The first one is kinda a stretch, and I didn't expect it to work. My natural reaction was to try the second and third, thinking that grouping it would do the trick. It didn't though.
This came up in the web application I'm working on. There's a form with let's the user assign IDs to textual names. The name sometimes contain brackets, which triggered this issue.
BeanWrapperImpl.java:610 (1.2.4 source) is the cause. The parser could count braces, and return the key when it's found the first matching pair. In the example above, the first ] would be part of the key, and the second, which completes the initial pair, would complete the key. This solution would work regardless of the single or double quotes. An alternative would be to ignore braces that are in quoted ections of the string. This naturally would only work for scenarios #2 and #3 above.
I will try to update BeanWrapperImpl.java with a sllightly more sophisticated bracket parser and submit a patch with tests. If you think it's a waste of time, or if there's something obvious I'm missing, feel free to point out my error. Regards, Christian
Affects: 1.2.4
Attachments:
- MapBindingTests.java (2.04 kB)
- spr-1274-patch-1.txt (7.68 kB)
- spr-1274-patch-2.txt (8.51 kB)
Issue Links:
- Incorrect string parsing of mapped property names [SPR-2294] #6983 Incorrect string parsing of mapped property names ("is duplicated by")
5 votes, 4 watchers