Skip to content

Re: SPR-8941: Lifecycle processing ignores phases for circularly dependent SmartLifecycle beans #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eyealike
Copy link

First stab at a fix this issue. For discussion see http://jira.springsource.org/browse/SPR-8941.

@cbeams
Copy link
Contributor

cbeams commented May 17, 2012

Hi Hannes,

Per my comments on SPR-8941, this is looking pretty good with regard to content. Please read through and follow the contributor guidelines (which didn't exist when you first submitted this pull request), and we'll go from there.

A couple things that aren't expressly in the guidelines:

  • whitespace in method invocations/declarations (getPhase(bean), not getPhase( bean ), etc)
  • braces on same line, not newline, etc
  • don't use final on local variables unless necessary (nothing wrong with this, it just hasn't been the convention in the rest of the framework)

Thanks!

@ghost ghost assigned cbeams May 17, 2012
bclozel added a commit that referenced this pull request Dec 16, 2015
Fix directory name for sample pages
@pivotal-issuemaster
Copy link

@eyealike Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@rstoyanchev
Copy link
Contributor

Closing as the related issue is closed too.

@pivotal-cla
Copy link

@eyealike Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@rstoyanchev rstoyanchev removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 12, 2021
cesarhernandezgt added a commit to cesarhernandezgt/spring-framework that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants