Fix memory leak in MHistorConfig & MBeanExpHelper #2531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MessageHistoryConfigurer` is a `BeanPostProcessor` which keeps a store of the `TrackableComponent`. Something similar we have with the `MBeanExporterHelper` and its local stores populated by the `postProcessBeforeInitialization()` * Implement `DestructionAwareBeanPostProcessor` in the `MessageHistoryConfigurer` and `MBeanExporterHelper` to remove destroyed beans from their caches **Cherry-pick to 5.0.x**
garyrussell
suggested changes
Jul 27, 2018
|
|
||
| private final Set<String> siBeanNames = new HashSet<String>(); | ||
| private final Set<String> siBeanNames = new HashSet<>(); |
There was a problem hiding this comment.
I think this needs to be made concurrent to handle dynamic add/remove. See MessageHistoryConfigurer.
* Apply Java 8 style for collections iterations
garyrussell
approved these changes
Jul 27, 2018
garyrussell
pushed a commit
that referenced
this pull request
Jul 27, 2018
* Fix memory leak in MHistorConfig & MBeanExpHelper The `MessageHistoryConfigurer` is a `BeanPostProcessor` which keeps a store of the `TrackableComponent`. Something similar we have with the `MBeanExporterHelper` and its local stores populated by the `postProcessBeforeInitialization()` * Implement `DestructionAwareBeanPostProcessor` in the `MessageHistoryConfigurer` and `MBeanExporterHelper` to remove destroyed beans from their caches **Cherry-pick to 5.0.x** * * Fix concurrency and checkstyle * Apply Java 8 style for collections iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MessageHistoryConfigureris aBeanPostProcessorwhich keeps astore of the
TrackableComponent.Something similar we have with the
MBeanExporterHelperand its localstores populated by the
postProcessBeforeInitialization()DestructionAwareBeanPostProcessorin theMessageHistoryConfigurerandMBeanExporterHelperto remove destroyedbeans from their caches
Cherry-pick to 5.0.x