GH-3660: Invoke well-known lambdas explicitly #3883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your "Fixes" points to the wrong place; should be #3660 (Commit headline too). |
Fixes spring-projects#3660 * Change the `LambdaMessageProcessor` to invoke `Function`, `GenericHandler`, `GenericSelector` & `GenericTransformer` explicitly without reflection. This allows to avoid `--add-opens` for Java types to be used from reflections. Plus this removes some overhead with native images. And in general it is faster than reflection invocation.
artembilan
changed the title
|
Edited and re-pushed. |
garyrussell
reviewed
Sep 7, 2022
| return this.method.invoke(this.target, args); | ||
| } | ||
|
|
||
| /* TODO when preview features are available in the next Java version |
There was a problem hiding this comment.
This might need a NOSONAR (TODO).
There was a problem hiding this comment.
I think that's OK: will give us an extra reminder to not forget to fix this eventually 😄
There was a problem hiding this comment.
Either way our Sonar instance does not support Java 17 yet: https://stackoverflow.com/questions/71528775/migrate-sonarqube-to-support-java-17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3660
LambdaMessageProcessorto invokeFunction,GenericHandler,GenericSelector&GenericTransformerexplicitly without reflection. This allows to avoid--add-opensfor Java types to be used from reflections. Plus this removes some overhead with native images. And in general it is faster than reflection invocation.